Update native.py: try typing TAllowedParameterValue more completely #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyattscarpenter
had a problem deploying
to
azure-prod
GitHub Actions
Failure
wyattscarpenter
had a problem deploying
to
azure-prod
GitHub Actions
Failure
|
Sure wish there were a way to signoff from the web interface, ugh... |
This is a stab at fixing databricks#669; I'm not sure it's correct, but if it is then it will probably save somebody some time down the road if I make this PR now. Signed-off-by: wyattscarpenter <[email protected]>
wyattscarpenter
force-pushed
the
patch-2
branch
from
790158b to
7edb4a9
Compare
wyattscarpenter
had a problem deploying
to
azure-prod
GitHub Actions
Failure
wyattscarpenter
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: wyattscarpenter <[email protected]>
wyattscarpenter
had a problem deploying
to
azure-prod
GitHub Actions
Failure
wyattscarpenter
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: wyattscarpenter <[email protected]>
wyattscarpenter
had a problem deploying
to
azure-prod
GitHub Actions
Failure
wyattscarpenter
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: wyattscarpenter <[email protected]>
wyattscarpenter
had a problem deploying
to
azure-prod
GitHub Actions
Failure
wyattscarpenter
had a problem deploying
to
azure-prod
GitHub Actions
Failure
|
I feel like the CI failures might not be related to my changes. |
| dict, | ||
| tuple, | ||
| list["TAllowedParameterValue"], | ||
| dict["TAllowedParameterValue", "TAllowedParameterValue"], |
There was a problem hiding this comment.
nit: is dict[str, "TAllowedParameterValue"] more appropriate?
There was a problem hiding this comment.
Quite possibly, quite possibly! (I don't know; I didn't find out.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
A... type signature bug fix.
Description
This is a stab at fixing #669 by making some incomplete types into recursive types; I'm not sure it's correct, but if it is then it will probably save somebody some time down the road if I make this PR now.
How is this tested?
I hope your CI has a typechecking phase! If so, then that.
Related Tickets & Documents
#669